Adding 2022 Commander decks to be purchased in the Quest shop #5961
Conversation
| Credits=5000 | ||
| MinDifficulty=0 | ||
| MaxDifficulty=5 | ||
| [metadata] |
There was a problem hiding this comment.
@tehdiplomat
isn't there a better way yet than to duplicate these files? 😢
https://github.com/Card-Forge/forge/blob/master/forge-gui/res/quest/commanderprecons/Bedecked%20Brokers%20[NCC]%20[2022].dck
There was a problem hiding this comment.
Yea if we already have these files, then we should just have a list of directories of where to pull them from.
There was a problem hiding this comment.
They are in commanderprecons. I can just add the cost block to everything in there as long as the line in forge/forge-gui/src/main/java/forge/localinstance/properties/ForgeConstants.java):
public static final String QUEST_PRECON_DIR = QUEST_DIR + "precons" + PATH_SEPARATOR;
Can be coded to read from both directories.
There was a problem hiding this comment.
I think we might
but wouldn't it be better to only use them when quest is commander mode too? 🤔
There was a problem hiding this comment.
Maybe, depends if there are any useful cards in the precons. Isn't there a commander plane in the regular quest mode as well?
There was a problem hiding this comment.
There isn't but people might want to buy the precons for specific cards.
There was a problem hiding this comment.
@Sunnovah were you going to make the update? Just add prices to original spots, and have the files be pulled from both locations?
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
No description provided.