-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows for additional cards to be added to worlds.txt in quest mode. #6175
Open
repeperilka
wants to merge
8
commits into
Card-Forge:master
Choose a base branch
from
repeperilka:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehdiplomat
reviewed
Oct 13, 2024
…ide the directory for the world.
…t contain any files.
repeperilka
commented
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what I did here.
Hope I didn't mess anything up.
Just found out the changes I made break the spell shop for the Random Commander world |
…reated a world folder with worlds divided by planes.
…references file on their world directory. If such file doesn't exist, it'll use the default preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By writing "Extra:cardname@set;cardname@set..." you can get extra cards not found in the previously given sets into worlds in quest mode. When there are no allowed sets or additional cards, the world shop and pool will behave as it did before (It'll give cards from all sets), and if there are no allowed sets but there are additional cards, all of the cards shown on the store and initial card pool will only be composed of the additional cards specified.
To accommodate for this, the constructors for GameFormat and GameFormatQuest have been changed together with its filters and the return value of getAllCards() and when checking if a set is allowed in the format, the result will depend on if the format has additional cards.
Colored booster pack generation accounts for additional cards when building its filters
Added random colored boosters as win rewards called "Chaos" plus the color.
The function for generating singles in the shop now uses the same system as the initial card pool for starting a quest because it's faster.