Update CreatureEvaluator.java #6445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Break down the evaluation logic into smaller methods. Add comments to explain the purpose of each section. Add logging for debugging purposes. Implement a method to print the evaluation details for better insight.
tool4ever
reviewed
Oct 27, 2024
| } | ||
|
|
||
| // TODO no longer a KW |
There was a problem hiding this comment.
let's not remove any unaddressed TODO or otherwise useful comments
There was a problem hiding this comment.
I feel like a few other ones are still being removed
tool4ever
reviewed
Oct 27, 2024
| } | ||
| if (c.hasKeyword(Keyword.VANISHING)) { | ||
| value -= subValue(20 / (Math.max(1, c.getCounters(CounterEnumType.TIME))), "vanishing"); | ||
| value += subValue(20 / (Math.max(1, c.getCounters(CounterEnumType.TIME))), "vanishing"); |
There was a problem hiding this comment.
I do believe this breaks and would just increase now...
There was a problem hiding this comment.
can't the - be moved inside the addValue call instead so the debug output in SimulationCreatureEvaluator will be correct?
tool4ever
reviewed
Oct 27, 2024
| } else if (c.getSVar("SacrificeEndCombat").equals("True")) { | ||
| value -= subValue(40, "sac-end"); | ||
| value += subValue(40, "sac-end"); | ||
| } | ||
| if (c.hasKeyword("CARDNAME can't attack or block.")) { | ||
| value = addValue(50 + (c.getCMC() * 5), "useless"); // reset everything - useless |
There was a problem hiding this comment.
because of your splitting this reset is broken now
tool4ever
reviewed
Oct 27, 2024
tool4ever
reviewed
Oct 27, 2024
tool4ever
requested changes
Oct 27, 2024
Retained Unaddressed TODO Comment: Fixed the incorrect addition logic for the vanishing keyword to ensure it subtracts value correctly Corrected the section where the reset logic for useless cards was broken due to splitting Removed comments that only spell out the function name again, as they don't add additional information
|
i have made the neccessary changes please give it a look and if further changes are required you can let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break down the evaluation logic into smaller methods.
Add comments to explain the purpose of each section.
Add logging for debugging purposes.
Implement a method to print the evaluation details for better insight.