Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find issue with linear interpolation or plot of linear interpolation #28

Open
MichaelClerx opened this issue Dec 14, 2021 · 3 comments
Open
Labels

Comments

@MichaelClerx
Copy link
Member

MichaelClerx commented Dec 14, 2021

local-line-plot-macdui

Why do we see these some times?

I.E. did the optimiser not find the optimum, is it a plotting issue, or something else?

@EricWay1024
Copy link
Collaborator

I suppose it's because of the discrepancies between a local maximum point of the interpolant and the corresponding hill in the database.

image

I've come up with an idea to solve such discrepancy: find some local optimizer that has a small learning rate, and for each hill in the database, use its location as the starting point of the local optimizer. We'll end up somewhere near our starting point but with a larger height (we must check the proximity), and then we update the database with this point.

Or maybe there's a fixed discrepancy for all the hills? I.e. we simply need to move all the locations in the database by a fixed amount to match the hills with the local maxima. I haven't worked on this yet so I'm not sure.

@MichaelClerx
Copy link
Member Author

Hi Eric, Yeah the hills database doesn't agree with our data set entirely, and that's fine.

What worries me is why the red line above isn't exactly on the maximum of the blue line. Both are from our interpolant, so the hills db doesn't come into play here

@EricWay1024
Copy link
Collaborator

Oh, then I suppose that might have something to do with the optimizer, which might stop iterating only near the highest point, potentially because of its "minimum step"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants