New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This software should not be setting the logging level and logging at the same time :D #42

Open

MichaelClerx opened this issue Nov 18, 2024 · 1 comment

Member

MichaelClerx commented Nov 18, 2024

See here:

https://github.com/CardiacModelling/pcpostprocess/blob/main/pcpostprocess/hergQC.py#L33-L34

Basically, you should only set the logging level of stuff you are using. What we have now is just a fancy version of "print" so logging is overkill?

Also not sure what is happening with the "debug" setting in that file. Should it be on all the time?

Member Author

MichaelClerx commented Nov 18, 2024

Is this so that we can manually check the correct values are printed to screen? Cause if so that should become a proper unit test :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment