Skip to content
This repository was archived by the owner on Jul 30, 2025. It is now read-only.

Relay fee details: pocket money in fee token #292

Merged
merged 3 commits into from
Jul 23, 2025
Merged

Relay fee details: pocket money in fee token #292

merged 3 commits into from
Jul 23, 2025

Conversation

JanKuczma
Copy link
Collaborator

No description provided.

kroist
kroist approved these changes Jul 23, 2025
View reviewed changes
crates/shielder-relayer/src/fee.rs

/// The cost of pocket money in fee token.
#[schema(value_type = String)]
pub pocket_money_fee_token: U256,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's return pocket_money_native as well!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

Transaction NameMainCurrentDifference (%)
Deposit (size)20255202550.00000%
DepositERC20 (gas)17660991766063-0.00204%
DepositERC20Fees (gas)17747391774715-0.00135%
DepositERC20FeesMemo (gas)17755171775481-0.00203%
DepositERC20Memo (gas)176680517668050.00000%
DepositNative (gas)17483771748353-0.00137%
DepositNativeFees (gas)17577451757697-0.00273%
DepositNativeFeesMemo (gas)17585951758535-0.00341%
DepositNativeMemo (gas)17662431766171-0.00408%
NewAccount (size)22867228670.00000%
NewAccountERC20 (gas)17996551799715+0.00333%
NewAccountERC20Fees (gas)18083551808331-0.00133%
NewAccountERC20FeesMemo (gas)179215217921520.00000%
NewAccountERC20Memo (gas)17833681783404+0.00202%
NewAccountNative (gas)17642511764323+0.00408%
NewAccountNativeFees (gas)18158271815839+0.00066%
NewAccountNativeFeesMemo (gas)17744921774552+0.00338%
NewAccountNativeMemo (gas)17651121765148+0.00204%
Withdraw (size)21573215730.00000%
WithdrawERC20 (gas)18671611867257+0.00514%
WithdrawERC20Fees (gas)18417691841697-0.00391%
WithdrawERC20FeesMemo (gas)18426071842535-0.00391%
WithdrawERC20Memo (gas)18338231833763-0.00327%
WithdrawNative (gas)18674091867433+0.00129%
WithdrawNativeFees (gas)18268731826825-0.00263%
WithdrawNativeFeesMemo (gas)18447281844764+0.00195%
WithdrawNativeMemo (gas)18182121818080-0.00726%

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 23, 2025 •
edited
Loading

📊 Coverage Report

📈 Total Coverage Summary

Type Covered Total Coverage
📝 Lines 1722 2435 🟠 70.71%
📄 Statements 1722 2435 🟠 70.71%
⚡ Functions 115 132 🟡 87.12%
🔀 Branches 277 292 🟡 94.86%

Coverage Legend

  • ✅ 100% Coverage
  • 🟡 80-99% Coverage
  • 🟠 50-79% Coverage
  • ❌ 0-49% Coverage

📁 File Coverage

📋 Detailed Coverage Report
File Lines Statements Functions Branches
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/deposit.ts 89.74% 89.74% 100% 85.71%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/newAccount.ts 86.27% 86.27% 100% 80%
✅ zkOS-monorepo/ts/shielder-sdk/src/actions/types.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/actions/utils.ts 97.33% 97.33% 100% 90.9%
🟠 zkOS-monorepo/ts/shielder-sdk/src/actions/withdraw.ts 78.14% 78.14% 87.5% 100%
❌ zkOS-monorepo/ts/shielder-sdk/src/chain/contract.ts 1.8% 1.8% 0% 0%
❌ zkOS-monorepo/ts/shielder-sdk/src/chain/relayer.ts 32.94% 32.94% 33.33% 50%
✅ zkOS-monorepo/ts/shielder-sdk/src/client/actions.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/client/client.ts 88.13% 88.13% 71.42% 85.71%
✅ zkOS-monorepo/ts/shielder-sdk/src/client/factories.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/client/types.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/constants.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/errors.ts 100% 100% 100% 100%
❌ zkOS-monorepo/ts/shielder-sdk/src/index.ts 0% 0% 100% 100%
❌ zkOS-monorepo/ts/shielder-sdk/src/protocolFees.ts 18.51% 18.51% 14.28% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/accountFactory.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/state/accountOnchain.ts 94.44% 94.44% 100% 77.77%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/accountRegistry.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/accountStateSerde.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/idManager.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/localStateTransition.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/sync/chainStateTransition.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/sync/historyFetcher.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/sync/synchronizer.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/sync/tokenAccountFinder.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/state/types.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/storage/storageManager.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/storage/storageSchema.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/types.ts 100% 100% 100% 100%
✅ zkOS-monorepo/ts/shielder-sdk/src/utils.ts 100% 100% 100% 100%
🟡 zkOS-monorepo/ts/shielder-sdk/src/utils/errorHandler.ts 93.33% 93.33% 100% 75%

@JanKuczma JanKuczma requested a review from kroist July 23, 2025 10:44
@JanKuczma JanKuczma merged commit a92a411 into main Jul 23, 2025
11 checks passed
@JanKuczma JanKuczma deleted the relayer-fee-details branch July 23, 2025 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@kroist kroist kroist approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JanKuczma @kroist