Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Pin Rollup v4 #61

Merged
merged 1 commit into from
Jan 9, 2025
Merged

chore(deps): Pin Rollup v4 #61

merged 1 commit into from
Jan 9, 2025

Conversation

donmccurdy
Copy link
Member

Pins rollup v4 to resolutions. Previously Vite was using v4 (examples, local testing) but microbundle was using v2 (library builds). I tried switching over entirely to Vite, using Vite's Library Mode for the library builds (#60) but — as awesome as Vite is for building applications! — it seems really finicky for building libraries, I needed a lot of unexpected configuration just to get things working, and even then I couldn't get the sourcemaps or code coverage working.

It looks like Microbundle is already working on an update for Rollup, so I'd rather keep using that for now. We can remove the pinned resolution after the next Microbundle update, I'm tracking these issues:

@donmccurdy
Copy link
Member Author

Aside - I'm also curious about where Vite is going with Rolldown. Once that's stable, Vite will stop using Rollup and Esbuild, and just use Rollup – maybe the configuration will be simpler then, it might be a good time to revisit Vite Library Mode.

@donmccurdy
Copy link
Member Author

donmccurdy commented Jan 8, 2025

Small additional fix here is adding @types/react, we don't use React in this repo really, but the types are needed by the web component examples for React integration, without them we get warnings in build logs. I removed those types prematurely in #59.

@donmccurdy donmccurdy merged commit a360e8e into main Jan 9, 2025
4 checks passed
@donmccurdy donmccurdy deleted the chore/deps-rollup-v4 branch January 9, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants