Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browserify editor3 #7337

Merged
merged 6 commits into from
May 10, 2016
Merged

Browserify editor3 #7337

merged 6 commits into from
May 10, 2016

Conversation

rochoa
Copy link
Contributor

@rochoa rochoa commented May 9, 2016

Deprecates factor-bundle, uses browserify's external/require internals to use several bundles.

Contrary to previous solution it works with linked modules.

cc @alonsogarciapablo @viddo @xavijam

@viddo
Copy link
Contributor

viddo commented May 10, 2016

Does this have the same output (bundles/results) as factor-bundle yielded?

Contrary to previous solution it works with linked modules.

(For future reference) what does "works with linked modules" really mean?

What goes for the changes look legit so 👍

@alonsogarciapablo
Copy link
Contributor

I'm giving this a try, but it looks 👍

@rochoa
Copy link
Contributor Author

rochoa commented May 10, 2016

@viddo If you were doing:

npm link cartodb.js
npm link cartodb-deep-insights.js

It was not generating the same bundles, missing some dependencies in common bundle, as when you were just npm installing them.

Some refs:

@alonsogarciapablo
Copy link
Contributor

Working 👍

@rochoa rochoa merged commit ca139e5 into master May 10, 2016
@rochoa rochoa deleted the browserify-editor3 branch May 10, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants