Skip to content

No led change during run on the air #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WARIO2412 merged 1 commit into from
Mar 27, 2026
+2 −1
Merged

No led change during run on the air #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/modules/utils/mainbutton/MainButton.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,7 @@ void MainButton::on_set_public_data(void* argument)
uint32_t MainButton::led_tick(uint32_t dummy)
{
uint8_t state = THEKERNEL->get_state();
if (!this->button_pressed){
if (!this->button_pressed && THECONVEYOR->is_idle()){
switch (state) {
case HOLD:
this->hold_toggle ++;
Expand Down
1 change: 1 addition & 0 deletions version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- Fixed: Manual toolchanges after starting a file on an atc machine should work correctly now
- Fixed: Changing to the laser on an air with an atc works now
- Fixed: Clamping the spindle rpm to the max rpm fixed
- Fixed: No LED change during run to prevent step losses (blinking leads to missing steps and can be clearly heard)
- Change: added -Slow parameter to windows powershell build script to improve readability of error logs as the cost of speed.
- Change: removed register specifiers in LPC1768 and mbded libraries used by the project. register has been depreciated for a long time and now falls back to being completely ignored. Looked for library updates first, they haven't been updated.
- Change: Ext out on the CA1 and extend on C1 will turn off on halt (can be reverted to previous behaviour with config-set sd switch.extendout.failsafe 1)
Expand Down
Loading