Fusion post processor - 3d probing features#3
Draft
MFlego wants to merge 1 commit intoCarvera-Community:devfrom
Draft
Fusion post processor - 3d probing features#3MFlego wants to merge 1 commit intoCarvera-Community:devfrom
MFlego wants to merge 1 commit intoCarvera-Community:devfrom
Conversation
|
Is this ready for review? If not lets convert this to a draft PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@faecorrigan @hagmonk
This PR is attempting to try and re-incorporate experimental probe features that I worked on back in May of 2024 when there was a single repository for the community work named "CarveraCommunityFirmware". At the time I was working in a branch called "CC_FusionPost".
https://discord.com/channels/910194756473225269/1050263267769057351/1247395246514638919
I've squashed the entire work into this single commit because I honestly don't know how to transfer git history from one repo to another for just one file.
The work here introduces a common but new function into this post processor called OnCyclePoint() which I interpreted from the post processor training guide, as the intended place for translating the probing functions from the Fusion MFG workspace dialog here.
While this does accommodate WCS probing it currently does not address "inspection" which is a part of the probe geometry features.
There is still quite a bit of work to do in order to leverage the math functions Fae implemented in the community firmware and also some merge massaging. Any help with the work is very welcomed.