Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to napi versions to support Node 12 #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

baparham
Copy link

I was looking for node 12 support and this seemed to work so I thought I would file a PR to see if you think it should go into the main repo.

@baparham
Copy link
Author

Seems like perhaps the CI file should also be updated to test against node 12. I can push another commit that will hopefully address that

@zbynek
Copy link

zbynek commented Dec 10, 2019

This (+ some unrelated code cleanup) was already proposed in #62

@baparham
Copy link
Author

Thanks for engaging @zbynek - I can see that the other requests have been open a while, is it basically just held up with the maintainer(s)?

I also had the thought that perhaps a -napi fork of windows-registry should be published to the registry so that users might choose between the NAPI enabled version and this one depending on their node versions, but it seems like fixing this one and making it backward compatible with currently support node versions seems to make the most sense. Thoughts?

@simonbuchan
Copy link

If there's interest, I did end up writing an NAPI package native-reg after opening #62, but be warned it has an incompatible C-style API at the moment, so it's not drop-in. I'm happy to take requests, including API changes though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants