Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1593 Fix error 'Could not launch activity' in Espresso tests #5033

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

reichli
Copy link
Contributor

@reichli reichli commented Sep 12, 2024

Android OS can only start activities if they are listed in the app's Manifest. Activities created for testing purposes were therefore moved into the debug source set and listed in the corresponding debug Manifest. When the app us built for testing those activities will be available but not when the app is built for release.

https://catrobat.atlassian.net/browse/CATROID-1593

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Android OS can only start activities if they are listed in the app's
Manifest. Activities created for testing purposes were therefore
moved into the debug source set and listed in the corresponding debug
Manifest. When the app us built for testing those activities will be
available but not when the app is built for release.
Copy link
Contributor

@JayTropper JayTropper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants