CATROID-1481 Fix bug in 'Single tap at' brick #5038
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://catrobat.atlassian.net/browse/CATROID-1481
When brick coordinates added and read with e.g. 'Show variable' brick at runtime, then the x and y coordinate had one value less than previously assigned.
This is a bug in the libgdx library. In our version of libgdx the
Camera.unproject()
method, with which we come from the screen coordinates back to the stage coordinates, calculates y like that:y = Gdx.graphics.getHeight() - y - 1;
. The -1 is unnecessary and in theCamera.project()
function, it is not added to the worldcoordinates. However in the new version of libgdx, y is calculated like that:y = Gdx.graphics.getHeight() - screenCoords.y - viewportY;
, which would be correct (see https://github.com/libgdx/libgdx/blob/master/gdx/src/com/badlogic/gdx/graphics/Camera.java#L195C1-L195C99). In this bug fix I just added +1 to the y coordinate when touch is applied. Furthermore I appliedMath.round()
for both x and y, in order to fix rounding errors on the one hand and on the other fix the off-by-one error for the x coordinate.Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.