Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE-271 Typographic hierarchy should be visible #5047

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Frajhamster
Copy link
Contributor

@Frajhamster Frajhamster commented Nov 3, 2024

Jira ticket: https://catrobat.atlassian.net/browse/IDE-271

Description:

  • Improved backpack menus UI

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

Copy link
Contributor

@JayTropper JayTropper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the header to Copyright (C) 2010-2024 The Catrobat Team in every file where the year is not 2024 and remove the merge commit you did. If you need help with GIT you can just text me.

Comment on lines +301 to +303
Pair[] items = new Pair[] {
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout),
new Pair<String, Integer>(getString(R.string.delete), R.drawable.ic_delete)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to get rid of the warning Raw use of parameterized class 'Pair' by using Lists as bellow:

Suggested change
Pair[] items = new Pair[] {
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout),
new Pair<String, Integer>(getString(R.string.delete), R.drawable.ic_delete)};
List<Pair<String, Integer>> items = Arrays.asList(
new Pair<>(getString(R.string.unpack), R.drawable.ic_logout),
new Pair<>(getString(R.string.delete), R.drawable.ic_delete)
);

Comment on lines +485 to +487
Pair[] items = new Pair[] {
new Pair<String, Integer>(getString(R.string.pack), R.drawable.ic_login),
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the same as in BackpackRecyclerViewFragment.java.

Comment on lines +856 to +858
Pair[] items = new Pair[] {
new Pair<String, Integer>(getString(R.string.pack), R.drawable.ic_login),
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout)};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the same as in the other files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants