-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDE-271 Typographic hierarchy should be visible #5047
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the header to Copyright (C) 2010-2024 The Catrobat Team
in every file where the year is not 2024 and remove the merge commit you did. If you need help with GIT you can just text me.
Pair[] items = new Pair[] { | ||
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout), | ||
new Pair<String, Integer>(getString(R.string.delete), R.drawable.ic_delete)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to get rid of the warning Raw use of parameterized class 'Pair'
by using Lists as bellow:
Pair[] items = new Pair[] { | |
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout), | |
new Pair<String, Integer>(getString(R.string.delete), R.drawable.ic_delete)}; | |
List<Pair<String, Integer>> items = Arrays.asList( | |
new Pair<>(getString(R.string.unpack), R.drawable.ic_logout), | |
new Pair<>(getString(R.string.delete), R.drawable.ic_delete) | |
); |
Pair[] items = new Pair[] { | ||
new Pair<String, Integer>(getString(R.string.pack), R.drawable.ic_login), | ||
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the same as in BackpackRecyclerViewFragment.java
.
Pair[] items = new Pair[] { | ||
new Pair<String, Integer>(getString(R.string.pack), R.drawable.ic_login), | ||
new Pair<String, Integer>(getString(R.string.unpack), R.drawable.ic_logout)}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the same as in the other files.
Jira ticket: https://catrobat.atlassian.net/browse/IDE-271
Description:
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.