Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CATROID-1071 GoToRandomPositionAction refactor #5052

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

erikcoxx98
Copy link

@erikcoxx98 erikcoxx98 commented Nov 12, 2024

Refactor GoToRandomPositionAction.java and GoToRandomPositionActionTest.java to Kotlin - Ticket 1071

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@dorianpercic dorianpercic self-requested a review November 13, 2024 17:14
@Rule
val exception: ExpectedException = ExpectedException.none()

private var sprite: Sprite? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer, if all the three variables would be initialized with the lateinit key word as follows:

Suggested change
private var sprite: Sprite? = null
private lateinit var sprite: Sprite

Gives the code a cleaner look, since we you can then remove all the !! operators from the method calls.

sprite!!.look.xInUserInterfaceDimensionUnit = 0f
sprite!!.look.yInUserInterfaceDimensionUnit = 0f

Assert.assertEquals(0f, sprite!!.look.xInUserInterfaceDimensionUnit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace all Assert.assertEquals() with the simple assertEquals() from junit.framework.TestCase.assertEquals, since it is deprecated.

Refactor GoToRandomPositionAction.java and GoToRandomPositionActionTest.java to Kotlin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants