Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catty 710 turn object overview from list to segments #1828

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

lucatp
Copy link
Contributor

@lucatp lucatp commented Aug 17, 2023

Implementation for Ticket Catty 710

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

lucatp added 15 commits July 13, 2023 12:16
Passing the Sprite Object to the new Object View controller now works
Basic Implementation of Catty 710. However the backgrounds still causing issues and there are still some bugs to resolve.
Added Play Button Action for Scripts and fixed issue where the label add scripts was shown although there were already scripts
Fixed the dequeue error but tables are still not displayed correctly
Now using Container Views with segues which makes life much easier in this case
Implemented Navigation Bar Items for Scripts and Backgrounds
Implemented Navigation Bar Items for Sound
Added Gesture Recognizer and removed unused functions
Adjusted the size of the segmented Control
Added delegate to LooksTableVC, fixed Buttons and Toolbar fixed for moving Backgrounds.
Implemented the SegmentedControllDelegate for ScriptsVC and SoundsVC and refactored Code.
Fixed Bug where Delete Button on Scrips was disabled when backgrounds list was empty.
@lucatp lucatp requested a review from wallisch August 17, 2023 13:52
@lucatp lucatp self-assigned this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant