Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STCC-307] Standard setRotationStyle wrong conversion #224

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[STCC-307] Standard setRotationStyle wrong conversion #224

wants to merge 4 commits into from

Conversation

lildeaf
Copy link
Contributor

@lildeaf lildeaf commented Jun 7, 2021 •
edited by TauBossss
Loading

Please enter a short description of your pull request and add a reference to the Jira ticket.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline (Replace occurences of CATROBAT or CAT with STCC)
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • Post a message in the #stcc Slack channel and ask for a code reviewer

@TauBossss TauBossss self-requested a review June 9, 2021 13:58
TauBossss
TauBossss requested changes Oct 18, 2021
View reviewed changes
Copy link

@TauBossss TauBossss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rotation_style == "all around" is missing

@TauBossss TauBossss self-requested a review October 18, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TauBossss TauBossss TauBossss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lildeaf @TauBossss