Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STCC-318 and 317 Convert Hide/Show Variable [TN] #243

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

TauBossss
Copy link

I refactored the Hide/Show Variable block. It was previously done with a workaround, now these two bricks exists.
Before merging read this:
The problem is that the previous mentioned workaround still is active for Hide/Show lists and for the monitors. These bricks are not available in Catrobat. This can result in a not very good converted Catrobat project, if a lot of monitors with text are used.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline (Replace occurences of CATROBAT or CAT with STCC)
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • Post a message in the #stcc Slack channel and ask for a code reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant