Update and rename world-capitals.ssc to world-cities.ssc #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cities included are: - Primary capital cities - Cities with over 1 million people, up to 10 most populous cities per country/territory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cities included are:
As of writing, this is a proof-of-concept, and is rather rough — main issue is that the largest cities are often part of metropolitan areas (example: Tokyo, Saitama, Kawasaki, and Yokohama), which means you have a bunch of large cities very close to each other. This also means some notable cities may not show up due to being too small — the final version would probably include a number of hand-picked cities, and probably a more sophisticated city selection algorithm that can exclude neighbouring large cities in favour for less populous large cities which are located further out. Also, I welcome suggestions for ways to calculate Importance of the cities — the current one is basically engineered to yield sort of acceptable values.
Due to the renaming, approval of this PR would need to be accompanied by an update to celestia.cfg in Celestia.