Skip to content

Conversation

@futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 3, 2025

  • Ticket: [ENG-9649]
  • Feature flag: n/a

Purpose

  • Use configurableApiRoot property from GravyValet to govern addons form controls

Summary of Changes

  • Serialize the configurableApiRoot property from GravyValet's external-services
  • Use this new property to determine whether we show/hide the "Host URL" field

Screenshot(s)

  • When authorizing a storage-provider, we should see that this first textbox is driven by this configurableApiRoot property
image

Side Effects

  • None

QA Notes

  • Please confirm that providers with user-configurable "Host URLs" (Dataverse, Gitlab, and ownCloud) still work as expected and users are able to set up their accounts and access their content on those providers

@coveralls
Copy link
Collaborator

coveralls commented Nov 3, 2025

Coverage Status

coverage: 53.834% (+0.001%) from 53.833%
when pulling 2fbcf46 on futa-ikeda:refactor/configurable-api-root
into 95a1cbc on CenterForOpenScience:develop.

@futa-ikeda futa-ikeda changed the title Use configurable api root [ENG-9649] Use configurable api root Nov 3, 2025
@futa-ikeda futa-ikeda force-pushed the refactor/configurable-api-root branch from e8b82c6 to 2fbcf46 Compare November 4, 2025 14:44
@nsemets
Copy link
Collaborator

nsemets commented Nov 4, 2025

@futa-ikeda Don't we need to merge into feature/pbs-25.03?

@futa-ikeda futa-ikeda changed the base branch from develop to feature/pbs-25.03 November 4, 2025 15:46
@futa-ikeda
Copy link
Contributor Author

I've changed the base branch for this PR. Appreciate the reminder!

@nsemets nsemets self-requested a review November 4, 2025 15:51
@futa-ikeda futa-ikeda merged commit 438954d into CenterForOpenScience:feature/pbs-25.03 Nov 4, 2025
3 checks passed
@futa-ikeda futa-ikeda deleted the refactor/configurable-api-root branch November 4, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants