Skip to content

[ENG-9242] Fix wrong < > & encoding #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2025
Merged

[ENG-9242] Fix wrong < > & encoding #742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2184872
fix wrong & < > encoding for preprints general info tab and browser …
mkovalua Nov 4, 2025
6b042af
remove redundant testing chars
mkovalua Nov 4, 2025
d924616
use helper function to format bad encoding
mkovalua Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...prints/components/preprint-details/general-information/general-information.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ <h3>{{ 'preprints.preprintStepper.review.sections.authorAssertions.publicData' |
<p>{{ 'preprints.preprintStepper.review.sections.authorAssertions.noData' | translate }}</p>
}
@case (ApplicabilityStatus.Unavailable) {
{{ preprintValue.whyNoData }}
{{ preprintValue.whyNoData | fixSpecialChar }}
}
@case (ApplicabilityStatus.Applicable) {
@for (link of preprintValue.dataLinks; track $index) {
Expand All @@ -46,7 +46,7 @@ <h3>{{ 'preprints.preprintStepper.review.sections.authorAssertions.publicData' |

<section class="flex flex-column gap-2">
<h3>
{{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }}
{{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }} eeee
Copy link
Collaborator

@nsemets nsemets Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }} eeee
{{ 'preprints.preprintStepper.review.sections.authorAssertions.publicPreregistration' | translate }}

</h3>

@switch (preprintValue.hasPreregLinks) {
Expand All @@ -56,7 +56,7 @@ <h3>
</p>
}
@case (ApplicabilityStatus.Unavailable) {
{{ preprintValue.whyNoPrereg }}
{{ preprintValue.whyNoPrereg | fixSpecialChar }}
}
@case (ApplicabilityStatus.Applicable) {
@switch (preprintValue.preregLinkInfo) {
Expand Down Expand Up @@ -101,7 +101,7 @@ <h3>{{ 'preprints.details.supplementalMaterials' | translate }}</h3>
<h3>{{ 'preprints.preprintStepper.review.sections.authorAssertions.conflictOfInterest' | translate }}</h3>

@if (preprintValue.hasCoi) {
{{ preprintValue.coiStatement }}
{{ preprintValue.coiStatement | fixSpecialChar }}
} @else {
<p>{{ 'preprints.preprintStepper.review.sections.authorAssertions.noCoi' | translate }}</p>
}
Expand Down
2 changes: 2 additions & 0 deletions ...reprints/components/preprint-details/general-information/general-information.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { ContributorsListComponent } from '@osf/shared/components/contributors-l
import { IconComponent } from '@osf/shared/components/icon/icon.component';
import { TruncatedTextComponent } from '@osf/shared/components/truncated-text/truncated-text.component';
import { ResourceType } from '@osf/shared/enums/resource-type.enum';
import { FixSpecialCharPipe } from '@osf/shared/pipes/fix-special-char.pipe';
import {
ContributorsSelectors,
GetBibliographicContributors,
Expand All @@ -39,6 +40,7 @@ import { PreprintDoiSectionComponent } from '../preprint-doi-section/preprint-do
IconComponent,
AffiliatedInstitutionsViewComponent,
ContributorsListComponent,
FixSpecialCharPipe,
],
templateUrl: './general-information.component.html',
styleUrl: './general-information.component.scss',
Expand Down
4 changes: 3 additions & 1 deletion src/app/shared/services/meta-tags.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Meta, MetaDefinition, Title } from '@angular/platform-browser';

import { ENVIRONMENT } from '@core/provider/environment.provider';
import { PrerenderReadyService } from '@core/services/prerender-ready.service';
import { FixSpecialCharPipe } from '@osf/shared/pipes/fix-special-char.pipe';

import { MetadataRecordFormat } from '../enums/metadata-record-format.enum';
import { HeadTagDef } from '../models/meta-tags/head-tag-def.model';
Expand Down Expand Up @@ -274,7 +275,8 @@ export class MetaTagsService {
const titleTag = headTags.find((tag) => tag.attrs.name === 'citation_title');

if (titleTag?.attrs.content) {
this.title.setTitle(`${String(this.defaultMetaTags.siteName)} | ${String(titleTag.attrs.content)}`);
const title = `${String(this.defaultMetaTags.siteName)} | ${String(titleTag.attrs.content)}`;
this.title.setTitle(FixSpecialCharPipe.prototype.transform(title));
Copy link
Collaborator

@nsemets nsemets Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is bad practice to use prototype. First inject pipe and then use it.
Here is code: private readonly fixSpecialCharPipe = inject(FixSpecialCharPipe);
this.title.setTitle(this.fixSpecialCharPipe.transform(title));

}
}
}
Expand Down