-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an ellipsoid tileset loader for flat terrain generation #908
base: main
Are you sure you want to change the base?
Conversation
Hi @jqntn - thanks for the pull request! Haven't dug through this yet, but I'd like to point you to PR #890, which is almost in, that adds custom ellipsoid support to cesium-native. For cesium-native, this means instead of passing the ellipsoid as a separate parameter, you can access it from Alternatively, if you see a circumstance where you'd want to use a different ellipsoid for terrain generation than you use for georeferencing, I'll point you to CesiumGS/cesium-unity#465. With that PR, you can change "From WGS84 Ellipsoid" to "From Ellipsoid Asset" or something of the sort on Cesium3DTileset in Unity, and add a property to it that takes a CesiumEllipsoid asset (a ScriptableObject that contains the ellipsoid's radii). Regardless, this looks good on a quick skim - please @ me when you're ready to have it reviewed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jqntn! I have a few suggestions for changes below. Let us know if anything is unclear, or if you want some help with any of it. We really appreciate your work on it so far!
Cesium3DTilesSelection/include/Cesium3DTilesSelection/EllipsoidTilesetLoader.h
Outdated
Show resolved
Hide resolved
Cesium3DTilesSelection/include/Cesium3DTilesSelection/EllipsoidTilesetLoader.h
Show resolved
Hide resolved
I'm moving this out of the July release for now, to give time to make a few more changes. |
Hi @kring! Any update on this? |
Really sorry, but we have to move this out of this month's release again. |
Hi,
This is a proposal to implement an ellipsoid tileset loader. It leverages the custom loader API and allows the
Cesium3DTileset
to generate terrain by creating an ellipsoidal surface.I believe this is equivalent to EllipsoidTerrainProvider in CesiumJS.
In my opinion, this can be very useful, especially on low-end devices, or if you simply don't have a tileset at your disposal.
Here is a Unity example using the raster overlay, which you can try on this branch using this version of the cesium-unity package:
CC @carlopiersanti