Fix missing ellipsoid parameters #956
Merged
+28
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kring could I trouble you to review this? I've been distracted juggling other things, and might not get to this as soon as I want to |
|
Looks good to me @azrogers! Can you please just update CHANGES.md, and then I'll merge this. |
azrogers
force-pushed
the
fix-missing-ellipsoid
branch
from
d50892a
to
42ae86b
Compare
|
@kring Updated CHANGES! |
Thanks! But isn't it true that these changes represent actual cases where the chosen ellipsoid wasn't considered? So the changelog can point to incorrect results when using a non-WGS84 ellipsoid, not just compiler errors in a debug mode? |
|
@kring Good catch! Updated the wording to be more accurate. |
|
Thanks @azrogers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Sean noted in #953, there's a few places in the codebase we're currently missing an ellipsoid parameter. These compile fine unless
CESIUM_DISABLE_DEFAULT_ELLIPSOIDis enabled, but they will cause incorrect results if not fixed. We should consider enablingCESIUM_DISABLE_DEFAULT_ELLIPSOIDon CI to catch these issues in the future.