Support schemaUri property of EXT_structural_metadata
#969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #727, though
EXT_structural_metadatacan specify a schemaUri that contains the URI of a JSON file to load instead of the embedded schema, we don't currently support this property. This change adds that support.As part of the change, I gave the generate-classes tool some idea of what a "shared asset" is, so it can now generate a shared asset property directly rather than needing to mess with derived classes like in the case of
Image/ImageSpec. The largest change, by lines of code, is that agetSizeBytesmethod is now generated for every type. This is necessary for theSharedAssetDepotto know when it's "full."Code needs cleanup, especially the JavaScript code which I don't have a formatter set up for. Also need to test in each of the runtimes - if there's any changes needed, they'll be small, but I haven't checked yet.