Add missing scale factor to instanced translations #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2024
|
Sorry that I missed this... I don't think I want to scale the glTF instance translation directly this way. It should be built into the matrix that is currently called the yInvertMatrix. This is for consistency with the approach I described in my talk, at the very least, and may be more correct as well. I'll look at it in CesiumGS/cesium-native#942. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instanced translations were missing the
positionScaleFactor, which made instances stack on top of each other incorrectly. Thanks @WxpGiser for the fix!This fixes the translation errors in CesiumGS/cesium-native#942, but there are still lingering issues, so I'll leave that open for now.