Raster overlay lifecycle and doc improvements #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kring
changed the title
|
Thanks @j9liu, I've addressed all your feedback. In the doc for the Activate / Deactivate methods, I just removed the "add it to" / "remove it from" bits completely. They weren't adding much and the parenthetical was awkward. |
|
Thanks @kring ! Merging now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came out of this community forum post:
https://community.cesium.com/t/remove-clipping-cesiumpolygonrasteroverlay-added-during-runtime/32520/6
It makes it possible to call the
Destroy ComponentBlueprint function on a raster overlay from outside the Cesium3DTileset Actor, and have it actually work.It fixes a small bug where calling
Refreshon an inactiveCesiumRasterOverlaywould cause that overlay to appear on the tileset. Until the next time the Tileset was refreshed, and then it would disappear.It also adds some more detailed documentation for the
AddToTileset,RemoveFromTileset,Refresh,Activate, andDeactivatemethods onCesiumRasterOverlay.