Add support for ellipsoid-based voxels #1711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #1685, so merge that first.
Data provided by NCEI
This PR adds support for loading and rendering ellipsoid-based voxels. Unlike box voxels, ellipsoid-based voxels account for the curvature of the Earth, and are thus effective at displaying data across a large region on the globe.
Author checklist
Testing plan
Reach out to me offline for the pictured test data. You can also try out the sample tileset in CesiumJS's SampleData folder.
Known Issues
There are various visual artifacts... you may have noticed the dithering artifacts along the edges of the data, as well as the hole in the middle. These artifacts appear in CesiumJS as well, but they are hidden by either depth testing or linear interpolation.
There is also a purple stripe that might be the result of float imprecision with the shape math:[RESOLVED 08/05]