Open
Conversation
Contributor
Author
|
Addition: That also means that the di_has_partition variable in di.c is probably invalid / wrong, as it also doesn't correctly check the return code. That's not yet fixed with this PR, though. |
|
If you're still actively working on this PR... brainslug-wii/src/apploader/apploader_get_ios.c Lines 115 to 118 in 88a4069 Is this meant to still be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old code retried DI_Read calls until the return value was not negative. However, that never happens. DI_Read and most other DI functions have 1 as the success case, and positive numbers larger than 1 for errors. This means that without this PR, reads could sometimes fail (due to disc issues or whatever), and instead of noticing and retrying, Brainslug would just assume that the data was read correctly.