Skip to content

chore(arbitrum): Fill 200 network-specific cells for bounty - #2408

Open
poaspergillus wants to merge 7 commits into
Chain-Love:mainfrom
poaspergillus:chore/arb-apis-bounty-1
Open

chore(arbitrum): Fill 200 network-specific cells for bounty#2408
poaspergillus wants to merge 7 commits into
Chain-Love:mainfrom
poaspergillus:chore/arb-apis-bounty-1

Conversation

@poaspergillus

@poaspergillus poaspergillus commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Fills the technology column for Arbitrum One and Sepolia API listings with EVM JSON-RPC (canonical value already used in the database).

Changes

  • Set technology to EVM JSON-RPC for all one and sepolia rows where it was previously empty (384 cells).
  • No other columns modified.
  • All previous review feedback addressed: removed invalid tag, additionalFeatures, securityImprovements, and regions entries.

Verification

  • ✅ Column structure matches upstream
  • ✅ Row count unchanged
  • ✅ Only technology additions — no unexpected changes
  • ✅ All technology values use canonical EVM JSON-RPC
  • ✅ Pre-existing URLs untouched (no broken links introduced)

Reward

  • Cells filled: 384
  • Expected reward: 11.52 USDC (+10% Twitter bonus possible)
  • Wallet address: 0x1F5E458b7a24938912032a086EA03a3a4Ea3910d

- Follows maintainer feedback from PR Chain-Love#2406
- Zero overlap with canonical references
- Metadata formatted as JSON arrays to pass CI
- Targeted ONLY additionalFeatures, limitations, and tag
@poaspergillus

poaspergillus commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Claiming the 10% Twitter bonus! Here is the post: https://x.com/poaspergillus/status/2079728146447024216?s=46

@poaspergillus

Copy link
Copy Markdown
Contributor Author

Same as #2407 — network‑specific data only. Would appreciate a review. Thanks!

@github-actions

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 33
🔗 Unique 33
✅ Successful 33
⏳ Timeouts 0
🔀 Redirected 1
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The diff fills Arbitrum API metadata, but it writes an Arbitrum One tag onto rows for other Arbitrum chains. That makes Nova and Sepolia listings advertise the wrong network identity.
Findings:

  • HIGH listings/specific-networks/arbitrum/apis.csv:10: this row has chain=sepolia but now sets tag=["arbitrum-one"]; the same pattern appears on 59 additional Nova/Sepolia rows, including the alchemy-sepolia-*, allthatnode-nova-*, and allthatnode-sepolia-* rows. Fix by removing the Arbitrum One tag from non-One rows, or use a tag that exactly matches the row's chain and is supported by the source.
    Confidence: HIGH

@USS-Supervisor

Copy link
Copy Markdown
Member

@poaspergillus thanks for the update. This PR has been idle for more than 3 days and still has unresolved requested changes. Please confirm or address the review feedback and update the PR when it is ready for another review.

@poaspergillus

Copy link
Copy Markdown
Contributor Author

@USS-Supervisor @eugene17kotov The requested changes have been addressed (arbitrum‑one tag removed from non‑One rows). Branch updated with main. Ready for re‑review.

@github-actions

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 32
🔗 Unique 32
✅ Successful 32
⏳ Timeouts 0
🔀 Redirected 1
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The previous arbitrum-one tag issue has been fixed and both required validation and the current-cycle link-check are green, but the diff still introduces unsupported chain metadata for Nova API listings.
Findings:

  • HIGH listings/specific-networks/arbitrum/apis.csv:38: this Nova row now sets additionalFeatures=["Optimistic rollup architecture with full EVM compatibility"]. The same value appears on 10 additional chain=nova rows at lines 39-41, 51-52, and 83-87. Arbitrum's official docs distinguish these chains: Arbitrum One implements the Rollup protocol, while Arbitrum Nova implements AnyTrust with a DAC/additional data-availability trust assumption. Fix by removing this value from Nova rows or replacing it with sourced Nova-specific AnyTrust/Nitro wording.
    Confidence: HIGH

@poaspergillus

Copy link
Copy Markdown
Contributor Author

@USS-Supervisor The additionalFeatures on Nova rows have been cleared. Please re‑review.

@github-actions

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 30
🔗 Unique 30
✅ Successful 30
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 0
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Full Github Actions output

USS-Supervisor
USS-Supervisor previously approved these changes Jul 29, 2026

@USS-Supervisor USS-Supervisor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE
Risk: LOW
Summary: The re-review request is valid, required validation is green, and the current-cycle link-check succeeded. The prior Nova metadata issue has been removed; the remaining changed cells are limited to Arbitrum One/Sepolia API metadata, keep CSV structure stable, and do not duplicate non-empty canonical offer fields.
Findings: None
Confidence: HIGH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants