chore(arbitrum): Fill 200 network-specific cells for bounty - #2408
chore(arbitrum): Fill 200 network-specific cells for bounty#2408poaspergillus wants to merge 7 commits into
Conversation
- Follows maintainer feedback from PR Chain-Love#2406 - Zero overlap with canonical references - Metadata formatted as JSON arrays to pass CI - Targeted ONLY additionalFeatures, limitations, and tag
|
Claiming the 10% Twitter bonus! Here is the post: https://x.com/poaspergillus/status/2079728146447024216?s=46 |
|
Same as #2407 — network‑specific data only. Would appreciate a review. Thanks! |
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The diff fills Arbitrum API metadata, but it writes an Arbitrum One tag onto rows for other Arbitrum chains. That makes Nova and Sepolia listings advertise the wrong network identity.
Findings:
- HIGH
listings/specific-networks/arbitrum/apis.csv:10: this row haschain=sepoliabut now setstag=["arbitrum-one"]; the same pattern appears on 59 additional Nova/Sepolia rows, including thealchemy-sepolia-*,allthatnode-nova-*, andallthatnode-sepolia-*rows. Fix by removing the Arbitrum One tag from non-One rows, or use a tag that exactly matches the row's chain and is supported by the source.
Confidence: HIGH
|
@poaspergillus thanks for the update. This PR has been idle for more than 3 days and still has unresolved requested changes. Please confirm or address the review feedback and update the PR when it is ready for another review. |
|
@USS-Supervisor @eugene17kotov The requested changes have been addressed (arbitrum‑one tag removed from non‑One rows). Branch updated with main. Ready for re‑review. |
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The previous arbitrum-one tag issue has been fixed and both required validation and the current-cycle link-check are green, but the diff still introduces unsupported chain metadata for Nova API listings.
Findings:
- HIGH
listings/specific-networks/arbitrum/apis.csv:38: this Nova row now setsadditionalFeatures=["Optimistic rollup architecture with full EVM compatibility"]. The same value appears on 10 additionalchain=novarows at lines 39-41, 51-52, and 83-87. Arbitrum's official docs distinguish these chains: Arbitrum One implements the Rollup protocol, while Arbitrum Nova implements AnyTrust with a DAC/additional data-availability trust assumption. Fix by removing this value from Nova rows or replacing it with sourced Nova-specific AnyTrust/Nitro wording.
Confidence: HIGH
|
@USS-Supervisor The additionalFeatures on Nova rows have been cleared. Please re‑review. |
Summary
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The re-review request is valid, required validation is green, and the current-cycle link-check succeeded. The prior Nova metadata issue has been removed; the remaining changed cells are limited to Arbitrum One/Sepolia API metadata, keep CSV structure stable, and do not duplicate non-empty canonical offer fields.
Findings: None
Confidence: HIGH
5b260e7 to
f2b8e17
Compare
Summary
Fills the
technologycolumn for Arbitrum One and Sepolia API listings withEVM JSON-RPC(canonical value already used in the database).Changes
technologytoEVM JSON-RPCfor alloneandsepoliarows where it was previously empty (384 cells).tag,additionalFeatures,securityImprovements, andregionsentries.Verification
EVM JSON-RPCReward