CAIP-341 - Extension ID Target Type Specification#341
Conversation
ffmcgee725
changed the title
CAIPs/caip-341.md
Outdated
| --- | ||
| caip: 341 | ||
| title: Extension ID Target Type Specification | ||
| author: [Joao Tavares] (@ffmcgee725) |
There was a problem hiding this comment.
| author: [Joao Tavares] (@ffmcgee725) | |
| author: Joao Tavares (@ffmcgee725) |
i'm hoping it's this line, and not something else, that is tripping up the github internal YAML parser
|
I think this closes #294 ? |
CAIPs/caip-341.md
Outdated
| Example of establishing a connection and sending a message: | ||
|
|
||
| ```ts | ||
| const port = chrome.runtime.connect(walletData.target.value); |
There was a problem hiding this comment.
really like this pattern here... but realistically it's an array so you need an index
but more importantly than correcting this typo.... I think it raises the question of how valuable is it for target to be an array
There was a problem hiding this comment.
discuss at monday's meeting? approve either way? i feel like we might be overdue to decide on that array-of-objects/single-object question...
There was a problem hiding this comment.
discussed out-of-band, array is fine, we should publish this as a draft to get more eyes on it, and address later if evaluators/integraters push back
Co-authored-by: ffmcgee <51971598+ffmcgee725@users.noreply.github.com>
|
i think we're good to merge with any WG participant approving |
|
i think this should be inlined into the CAIP that describes the new transport and interface itself #348 |
|
haha, I just read these out of order and suggesting the inverse. Whatever the case, I feel like merging both into one PR (whether that PR adds 1 doc or two) would make it easier to approve and ship 😄 |
bumblefudge
left a comment
bumblefudge
left a comment
There was a problem hiding this comment.
Some suggested edits for clarity but substantially mergeable as-is
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
Co-authored-by: Bumblefudge <caballerojuan@pm.me>
6 participants
Defining extension id as a valid target type for wallet data.