CAIP-341 - Extension ID Target Type Specification #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmcgee725
changed the title
adonesky1
reviewed
Dec 12, 2024
adonesky1
reviewed
Dec 12, 2024
adonesky1
reviewed
Dec 12, 2024
adonesky1
reviewed
Dec 12, 2024
jiexi
reviewed
Dec 12, 2024
jiexi
reviewed
Dec 12, 2024
octavio12345300
approved these changes
Dec 27, 2024
bumblefudge
reviewed
Jan 9, 2025
CAIPs/caip-341.md
Outdated
| --- | ||
| caip: 341 | ||
| title: Extension ID Target Type Specification | ||
| author: [Joao Tavares] (@ffmcgee725) |
There was a problem hiding this comment.
Suggested change
| author: [Joao Tavares] (@ffmcgee725) | |
| author: Joao Tavares (@ffmcgee725) |
i'm hoping it's this line, and not something else, that is tripping up the github internal YAML parser
bumblefudge
approved these changes
Feb 6, 2025
|
I think this closes #294 ? |
pedrouid
reviewed
Mar 25, 2025
| Example of establishing a connection and sending a message: | ||
|
|
||
| ```ts | ||
| const port = chrome.runtime.connect(walletData.target.value); |
There was a problem hiding this comment.
really like this pattern here... but realistically it's an array so you need an index
but more importantly than correcting this typo.... I think it raises the question of how valuable is it for target to be an array
ffmcgee725
commented
Mar 27, 2025
| icon: string; | ||
| rdns: string; | ||
| // Optional properties | ||
| target?: { type: "caip341", value: any }[], |
There was a problem hiding this comment.
Suggested change
| target?: { type: "caip341", value: any }[], | |
| target?: { type: string, value: any }[], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining extension id as a valid target type for wallet data.