Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: devnet setup with curio #4760

Merged
merged 23 commits into from
Sep 18, 2024
Merged

ci: devnet setup with curio #4760

merged 23 commits into from
Sep 18, 2024

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Sep 11, 2024

Summary of changes

Changes introduced in this pull request:

  • Basic devnet with Curio + Forest.
  • Mining does not yet work with Forest. This will be addressed in subsequent PRs.
  • This devnet setup is not tested in CI since mining doesn't yet work.

Reference issue to close (if applicable)

Part of #4716

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih changed the title [WIP] ci: devnet setup with curio ci: devnet setup with curio Sep 18, 2024
@lemmih lemmih marked this pull request as ready for review September 18, 2024 11:44
@lemmih lemmih requested a review from a team as a code owner September 18, 2024 11:44
@lemmih lemmih requested review from ruseinov and sudo-shashank and removed request for a team September 18, 2024 11:44
Remove the devnet:

```shell
docker compose rm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd usually do ❯ docker compose down --rmi all -v to be thorough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth noting that it's a copy of the same script from the devnet compose.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Curio devnet will eventually replace the lotus-miner devnet, right? So, eventually, we'll only have a single copy of the file.

@ruseinov ruseinov self-requested a review September 18, 2024 12:15
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

some non-blocking nits

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be copied? Can we point to the existing files in the devnet/?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same applies for some of the other files, e.g., Lotus dockerfile or check.sh.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think files should be shared between the two devnet configurations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you expect those dockerfiles to be differ in the future? All in all, those are just regular builds for 2k networks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, it might make more sense to put them in a common directory. We can do it in a follow-up. All in all, if possible, I'd like to avoid duplication.

@lemmih lemmih added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit c1623d2 Sep 18, 2024
30 checks passed
@lemmih lemmih deleted the lemmih/devnet-curio branch September 18, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants