-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: devnet setup with curio #4760
Conversation
Remove the devnet: | ||
|
||
```shell | ||
docker compose rm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd usually do ❯ docker compose down --rmi all -v
to be thorough.
scripts/devnet-curio/check.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting that it's a copy of the same script from the devnet
compose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Curio devnet will eventually replace the lotus-miner
devnet, right? So, eventually, we'll only have a single copy of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
some non-blocking nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have to be copied? Can we point to the existing files in the devnet/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same applies for some of the other files, e.g., Lotus dockerfile or check.sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think files should be shared between the two devnet configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you expect those dockerfiles to be differ in the future? All in all, those are just regular builds for 2k networks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, it might make more sense to put them in a common directory. We can do it in a follow-up. All in all, if possible, I'd like to avoid duplication.
Summary of changes
Changes introduced in this pull request:
devnet
setup is not tested in CI since mining doesn't yet work.Reference issue to close (if applicable)
Part of #4716
Other information and links
Change checklist