Skip to content

chore: update dependencies, code cleanup#64

Merged
haikoschol merged 2 commits intoChainSafe:masterfrom
gordon-to:chore/deps
Nov 22, 2024
Merged

chore: update dependencies, code cleanup#64
haikoschol merged 2 commits intoChainSafe:masterfrom
gordon-to:chore/deps

Conversation

@gordon-to
Copy link
Copy Markdown
Contributor

@gordon-to gordon-to commented Oct 23, 2024 •
edited
Loading

  • Update github actions to remove deprecated actions see runs on my fork
  • Update and move golang-ci.yml to remove deprecated linters and use latest checks
  • Fix readme example to match function signature
  • move tests to _test packages where possible
  • move all examples to example_test.go and verify output where possible
  • rename receivers to match across files
  • export ErrPublicKeyAtInfinity error for proper use of error.Is

Dependencies updated

  • github.com/cosmos/go-bip39
  • github.com/gtank/merlin
  • github.com/stretchr/testify
  • golang.org/x/crypto

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gordon-to

This comment was marked as resolved.

Sign in to view
noot
noot reviewed Oct 23, 2024
View reviewed changes
Comment thread .golangci.yml Outdated
noot
noot reviewed Oct 23, 2024
View reviewed changes
Comment thread derive.go Outdated
noot
noot reviewed Oct 23, 2024
View reviewed changes
Comment thread derive.go Outdated
noot
noot reviewed Oct 23, 2024
View reviewed changes
Comment thread keys.go Outdated
noot
noot reviewed Oct 23, 2024
View reviewed changes
Comment thread keys.go Outdated
@gordon-to gordon-to requested a review from noot October 23, 2024 20:53
@gordon-to gordon-to changed the title chore: update dependencies chore: update dependencies, code cleanup Oct 23, 2024
noot
noot approved these changes Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

jimjbrettj
jimjbrettj reviewed Oct 30, 2024
View reviewed changes
Comment thread .github/workflows/checks.yml Outdated
jimjbrettj
jimjbrettj reviewed Oct 30, 2024
View reviewed changes
Comment thread sign.go
jimjbrettj
jimjbrettj reviewed Oct 30, 2024
View reviewed changes
Comment thread sign_test.go
jimjbrettj
jimjbrettj reviewed Oct 30, 2024
View reviewed changes
Comment thread .golangci.yml Outdated
jimjbrettj
jimjbrettj reviewed Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! Always love to get contributions. Have a few questions/comments, but overall is very nice

haikoschol
haikoschol approved these changes Oct 30, 2024
View reviewed changes
Comment thread vrf_test.go
Comment thread .github/workflows/checks.yml Outdated
Comment thread example_test.go
Comment thread example_test.go
Comment thread example_test.go
Comment thread example_test.go
Comment thread example_test.go
Comment thread example_test.go
Comment thread example_test.go
Comment thread example_test.go
@gordon-to gordon-to requested a review from jimjbrettj November 1, 2024 15:58
jimjbrettj
jimjbrettj approved these changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@jimjbrettj jimjbrettj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thank you for the contribution!

@haikoschol haikoschol merged commit 194103b into ChainSafe:master Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haikoschol haikoschol haikoschol approved these changes

+2 more reviewers

@noot noot noot approved these changes

@jimjbrettj jimjbrettj jimjbrettj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gordon-to @CLAassistant @haikoschol @noot @jimjbrettj