feat/utils: lru cache #3420
Merged
feat/utils: lru cache #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanishkatn
force-pushed
the
feat/k/lrucache
branch
2 times, most recently
from
c69a5a2 to
797bf46
Compare
kanishkatn
force-pushed
the
feat/k/lrucache
branch
from
797bf46 to
4a9be45
Compare
kanishkatn
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
jimjbrettj,
kishansagathiya and
dimartiro
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #3420 +/- ##
===============================================
+ Coverage 51.02% 51.04% +0.02%
===============================================
Files 231 232 +1
Lines 30753 30786 +33
===============================================
+ Hits 15691 15716 +25
- Misses 13383 13389 +6
- Partials 1679 1681 +2 |
EclesioMeloJunior
approved these changes
Aug 2, 2023
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Implements LRUCache.
It is being used in disputes-subsystem and few other places in the polkadot code. This is the crate polkadot is using https://docs.rs/lru/latest/lru/.
Tests
go test ./...Primary Reviewer
@timwu20