Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dot/sync): Implement state sync strategy #4425

Merged
merged 43 commits into from
Feb 3, 2025
Merged

feat(dot/sync): Implement state sync strategy #4425

merged 43 commits into from
Feb 3, 2025

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Dec 19, 2024 •
edited
Loading

Changes

Implements state sync strategy as the next step to be able to use the warp sync process.
This change includes:

  • State sync strategy implementation
  • Refactor StateRequestProvider
    • Move it as part of sync package
    • Use it in state retrieval script and state sync strategy
    • Tests
  • Strategy switching
  • Refactor sync service to create the strategies within it as we discussed here
    • Fix tests
  • Improve logs
    • Remove some redundant logs
    • Modify some log levels to clean up the "production" logs
  • Tests

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Closes: #4238

@dimartiro dimartiro linked an issue Dec 19, 2024 that may be closed by this pull request
Implement state sync strategy #4238
Closed
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from a1b63c3 to 36b57e0 Compare December 19, 2024 16:37
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 61d4a98 to 956d49d Compare December 19, 2024 16:47
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from 36b57e0 to 5ce032d Compare January 7, 2025 17:32
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch 2 times, most recently from f0aba98 to d6443a2 Compare January 8, 2025 15:43
@dimartiro dimartiro self-assigned this Jan 8, 2025
@dimartiro dimartiro marked this pull request as ready for review January 9, 2025 13:44
@dimartiro dimartiro added A-blocked issue or PR is blocked until something else changes. S-sync-polkadot related to particular network syncing. S-sync-kusama related to particular network syncing. C-complex Complex changes across multiple modules. Possibly will require additional research. S-sync-paseo related to particular network syncing. S-sync-westend related to particular network syncing. T-implementation this issue/pr is a new feature or functionality. labels Jan 13, 2025
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch 2 times, most recently from adfaa59 to eea6c27 Compare January 16, 2025 15:13
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 661797c to 66e5284 Compare January 16, 2025 15:15
haikoschol
haikoschol reviewed Jan 17, 2025
View reviewed changes
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from eea6c27 to 5337adf Compare January 20, 2025 13:07
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 8c9d871 to 3995c15 Compare January 20, 2025 13:24
@dimartiro dimartiro removed the A-blocked issue or PR is blocked until something else changes. label Jan 20, 2025
@dimartiro dimartiro force-pushed the diego/warpsync/strategy branch from 5337adf to 3eb6f56 Compare January 24, 2025 20:35
@dimartiro
Improve logs
2e4f180
@dimartiro
Add warp sync proof fixture
81b2d4f
@dimartiro
Move types to warpsync package
33670ce
@dimartiro
Fix findScheduledChange
509bf02
@dimartiro
Small changes
7be83d8
@dimartiro
Retrieve state and store it in in memory trie
ac77fde
@dimartiro
Store state in our db
a47374b
@dimartiro
Implement show metrics for state sync
6bf452e
@dimartiro
Implement StateRequestProvider as part of sync package
57f1b59
@dimartiro
Replace retrieve state script provider with the one in sync pkg
19e5c27
@dimartiro
Create and switch to state sync strategy
e204716
@dimartiro
Fix response type
0db590f
@dimartiro
Remove log
bdb3d96
@dimartiro
Add unit tests for StateRequestProvider
a1a50bc
@dimartiro
Remove TODO
1cef2d4
@dimartiro
Improve sync service config and creation
6beb27c
@dimartiro
Improve logs
c117721
@dimartiro
Fix lint
a4f90dd
@dimartiro
Fix tests
d801967
@dimartiro
Fix lint
4da39cd
@dimartiro
Simplify full sync switch
323afb2
@dimartiro
Add issue to comments
5fe1fc4
@dimartiro
Export error
0381368
@dimartiro
Fix typo
bbe0a73
@dimartiro
Remove unnecesary compact proof structure
5d14e70
@dimartiro
Fix license
c8ff5d6
@dimartiro
Fix mocks
9165a5b
@dimartiro dimartiro force-pushed the diego/statesync/strategy branch from 527803f to 9165a5b Compare February 3, 2025 14:08
@dimartiro dimartiro merged commit e0a30ef into development Feb 3, 2025
24 checks passed
@dimartiro dimartiro deleted the diego/statesync/strategy branch February 3, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haikoschol haikoschol haikoschol approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

@P1sar P1sar Awaiting requested review from P1sar P1sar is a code owner

Assignees

@dimartiro dimartiro

Labels
A-in-QA-or-regression pull request or issues is currently in QA or regression testing phase. C-complex Complex changes across multiple modules. Possibly will require additional research. S-sync-kusama related to particular network syncing. S-sync-paseo related to particular network syncing. S-sync-polkadot related to particular network syncing. S-sync-westend related to particular network syncing. T-implementation this issue/pr is a new feature or functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement state sync strategy
3 participants
@dimartiro @haikoschol @EclesioMeloJunior