Added conf option to scope wg hub to right netns #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to add the 'create_hub_in_root_netns' boolean option designed to scope the wireguard hub creation to the root network namespace if set to True. To set, add the option to the site's defaults.
|
Note! Requires code/container from this PR |
msherman64
reviewed
Jun 17, 2024
kolla/defaults.yml
Outdated
| @@ -257,6 +257,7 @@ neutron_dev_plugins: | |||
|
|
|||
| # minimal config for neutron wireguard agent | |||
| neutron_wireguard_hub_endpoint: "{{ kolla_external_vip_address }}" | |||
| create_hub_in_root_netns: "{{ create_hub_in_root_netns }}" | |||
There was a problem hiding this comment.
this needs a default:
normally I would say to default it to false so that just deploying the container won't change behavior.
however, as we're the only ones deploying this, lets set it to true because it will save some steps.
create_hub_in_root_netns to neutron_wireguard_create_hub_in_root_netns. A boolean to be added to defaults.yaml
msherman64
requested changes
Jun 21, 2024
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to add the 'create_hub_in_root_netns' boolean option designed to scope the wireguard hub creation to the root network namespace if set to True. To set, add the option to the site's defaults.