refactor mysql s3 backup task #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One concern (not sure best way to fix) is how to disable this. We'd basically need a "enable_mariadb_backup_auto" flag, and have ansible ensure the relevant scripts and timers are removed if not set to true. |
The primary change in this commit is to replace use of the "aws-cli" tool with "rclone", as the AWS tools are not compatible with ceph rgw based s3 implementations. Additionally, this removes support for the mysqldump based legacy backups, and refactors the backup script for readability and improved logging. Behavior changes: Rather than only the latest backup file, rclone will copy any new files that are not present in the object store, but will NOT overwrite existing ones.
msherman64
force-pushed
the
fix/refactor_mysql_backup
branch
from
e95d28d
to
923f3cf
Compare
|
What is actually creating the backups now? Is this syncing the volume data directly? |
The backups are created by a cronjob on the deploy host which executes the cron job here just handles rotating those backup files, and copying them from this docker volume to an object store bucket. |
Mark-Powers
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary change in this commit is to replace use of the "aws-cli"
tool with "rclone", as the AWS tools are not compatible with ceph rgw
based s3 implementations.
Additionally, this removes support for the mysqldump based legacy
backups, and refactors the backup script for readability and improved
logging.
Behavior changes:
Rather than only the latest backup file, rclone will copy any new files
that are not present in the object store, but will NOT overwrite
existing ones.