Skip to content

Conversation

@eirikvaa
Copy link

@eirikvaa eirikvaa commented Sep 25, 2024

Goals ⚽

Open up the autoScale method so that additional operations can be performed while auto scaling.

Our usage is this:

override func autoScale() {
    super.autoScale()
    notifyDataSetChanged()
}

We have enabled auto scaling and there are additional elements in the graph that rely on notifyDataSetChanged being called. We have maintained our own fork for this sole change, but if it's not too controversial, it would be nice to merge this change upstream.

Implementation Details 🚧

Nothing special, just declare the method as open instead of internal.

Testing Details 🔍

I don't think any tests are relevant here.

@eirikvaa eirikvaa changed the title Open up the autoScale method so it can be overriden Declare autoScale as open Sep 25, 2024
@eirikvaa eirikvaa closed this Mar 15, 2025
@eirikvaa eirikvaa reopened this Nov 7, 2025
@eirikvaa
Copy link
Author

eirikvaa commented Nov 7, 2025

@danielgindi Any objection to merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants