refactor: make Expression pure virtual

Chatterino · Oct 13, 2023 · 5bec8d4 · 5bec8d4
1 parent 6f5e6f0
commit 5bec8d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 24 deletions.
diff --git a/src/controllers/filters/lang/expressions/Expression.cpp b/src/controllers/filters/lang/expressions/Expression.cpp
@@ -2,24 +2,4 @@
 
 namespace chatterino::filters {
 
-QVariant Expression::execute(const ContextMap & /*context*/) const
-{
-    return false;
-}
-
-PossibleType Expression::synthesizeType(const TypingContext & /*context*/) const
-{
-    return IllTyped{this, "Not implemented"};
-}
-
-QString Expression::debug(const TypingContext & /*context*/) const
-{
-    return "";
-}
-
-QString Expression::filterString() const
-{
-    return "";
-}
-
 }  // namespace chatterino::filters
diff --git a/src/controllers/filters/lang/expressions/Expression.hpp b/src/controllers/filters/lang/expressions/Expression.hpp
@@ -16,10 +16,10 @@ class Expression
 public:
     virtual ~Expression() = default;
 
-    virtual QVariant execute(const ContextMap &context) const;
-    virtual PossibleType synthesizeType(const TypingContext &context) const;
-    virtual QString debug(const TypingContext &context) const;
-    virtual QString filterString() const;
+    virtual QVariant execute(const ContextMap &context) const = 0;
+    virtual PossibleType synthesizeType(const TypingContext &context) const = 0;
+    virtual QString debug(const TypingContext &context) const = 0;
+    virtual QString filterString() const = 0;
 };
 
 using ExpressionPtr = std::unique_ptr<Expression>;