Chat commands api #3209
Chat commands api #3209
Conversation
|
How does this pr work for commands that a user has disabled? |
Fossabot does not return information via their API for disabled commands, edit#2: Streamelements fixed in Chatterino/command-list-api@895cc91 |
Co-authored-by: Felanbird <[email protected]>
|
This works |
|
I feel like the changelog should be: |
There was a problem hiding this comment.
Functionality works as intended. 👍
On my first attempt testing this PR I was unable to properly replicate it in most channels, but I now realize I would have been the first person generating command lists for said channels, and if I had restarted then, the functionality would have worked.
Yeah this is probably better actually, especially if the future intention is to implement other bots. |
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| ## Unversioned | |||
|
|
|||
| - Major: Added the ability to autocomplete Fossabot & Streamelements commands. (#3209) | |||
There was a problem hiding this comment.
| - Major: Added the ability to autocomplete Fossabot & Streamelements commands. (#3209) | |
| - Major: Added support for bot command autocompletion using Chatterino's command list API: https://github.com/Chatterino/command-list-api (#3209) |
There was a problem hiding this comment.
I don't think that an average Chatterino user would care about the github link in a changelog entry. If someone's interested more into how this feature is going to work they have a PR number and can read up detail on the PR.
There was a problem hiding this comment.
| - Major: Added the ability to autocomplete Fossabot & Streamelements commands. (#3209) | |
| - Major: Added support for bot command autocompletion using Chatterino's command list API. (#3209) |
|
Fixes #2793 |
There was a problem hiding this comment.
This is a bit of a necro-review.
I like the feature, however there is a problem: when commands are loaded for the first time for a channel the API used to fail, this PR does not account for that. IMO that behavior should either be changed there or accounted for here.
| return Success; | ||
| }) | ||
| .onError([channelId](NetworkResult result) { | ||
| qCWarning(chatterinoFfzemotes) |
There was a problem hiding this comment.
Looks like a copy/paste mistake. I wouldn't expect custom chat commands to use FFZ logic.
| qCWarning(chatterinoFfzemotes) | |
| qCWarning(chatterinoTwitch) |
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Adds tab completion for bot commands using an api.