Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim disabled items in context menus #4423

Merged
merged 7 commits into from
Apr 29, 2023
Merged

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Mar 1, 2023

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

The items in the context-menu, that shows up when right-clicking the input, all had the same text color. When right-clicking in any other input, the text had an "etched" text effect (#1991). This PR dims these disabled items and removes the text-effect. I have no clue why setting a border disables this text effect. There are some references to an etch-diabled-text, but that doesn't seem to (have) work(ed).

Theme/State White Light Dark Black
Before 2023-03-01_19-33-43 chatterino_2023-03-01_19-33-31 firefox_2023-03-01_19-30-50 firefox_2023-03-01_19-33-14
After chatterino_2023-03-01_19-32-36 chatterino_2023-03-01_19-32-23 chatterino_2023-03-01_19-30-36 firefox_2023-03-01_19-32-49

Fixes #1991.

@Nerixyz Nerixyz changed the title Dim Disabled Items in the Input Context-Menu Dim Disabled Items in Context-Menus Mar 2, 2023
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as I would expect it to 👍

@pajlada pajlada marked this pull request as draft April 16, 2023 18:53
@pajlada
Copy link
Member

pajlada commented Apr 16, 2023

I imagine this should just be settable by the theme itself? now that themes are JSON-bound

remove draft & poke me when it's ready for review again and I can take a look

@Nerixyz Nerixyz marked this pull request as ready for review April 28, 2023 20:14
Copy link
Contributor

@Wissididom Wissididom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I noticed

CHANGELOG.md Outdated
@@ -27,6 +27,7 @@
- Bugfix: Fixed Twitch channel-specific filters not being applied correctly. (#4529)
- Bugfix: Fixed emote & badge tooltips not showing up when thumbnails were hidden. (#4509)
- Bugfix: Fixed links with invalid IPv4 addresses being parsed. (#4576)
- Bugfix: Fixed disabled items in context-menus having a weird or the default text color. (#4423)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Bugfix: Fixed disabled items in context-menus having a weird or the default text color. (#4423)
- Bugfix: Fixed disabled items in context-menus having a weird text-effect or the default text color. (#4423)

Not sure if that suggestion would be correct, but I wanted to point out that it seems to me that there is a word missing

Copy link
Contributor

@Wissididom Wissididom Apr 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I think about it, it might even have been correct, if so, I'm sorry

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression: The "behind tab" background doesn't update automatically with this

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on Linux

@pajlada pajlada changed the title Dim Disabled Items in Context-Menus Dim disabled items in context menus Apr 29, 2023
@pajlada pajlada enabled auto-merge (squash) April 29, 2023 16:47
@pajlada pajlada merged commit 6427184 into Chatterino:master Apr 29, 2023
@Nerixyz Nerixyz deleted the fix/contextmenu branch April 29, 2023 16:56
pajlada added a commit that referenced this pull request May 2, 2023
pajlada added a commit that referenced this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search box weird font issue
4 participants