Fix the menu position on macOS when using Qt 6.5 #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed working as expected on macOS Qt 6.5, macOS Qt 5.15, Arch Linux Qt 6.2.4, Arch Linux Qt 5.15 |
Felanbird
approved these changes
May 2, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reported in Discord by Trummler - see video: https://cdn.discordapp.com/attachments/459650160658481152/1103008038576721921/Bildschirmaufnahme_2023-05-02_um_19.19.36.mov
This happened because we called popup then move on the menu, and the position was only correct when the move call was called because the size had not yet been evaluated in the menu.
Instead, when figuring out the position, we now use the menu's sizehint which should be correct even before the menu is ever shown.