Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emoji unified/non-qualified version for sending & parsing #4840
Fix emoji unified/non-qualified version for sending & parsing #4840
Changes from all commits
abac7be
8d6834f
7d942a5
62548c3
af0a92b
424f0b7
93618aa
a9736f5
ff9d123
89129a8
bc8e731
027dcf6
5198a28
c479a6c
31026b3
92133d8
9531758
30458d9
1213173
8a1dfc2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: invalid case style for function 'BM_EmojiParsing' [readability-identifier-naming]
benchmarks/src/Emojis.cpp:136:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: variable 'tests' of type 'std::vector' can be declared 'const' [misc-const-correctness]
benchmarks/src/Emojis.cpp:75:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: invalid case style for function 'BM_EmojiParsing2' [readability-identifier-naming]
benchmarks/src/Emojis.cpp:166:
benchmarks/src/Emojis.cpp:170: