Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use override instead of virtual where possible #4917

Merged
merged 57 commits into from
Oct 25, 2023
Merged

refactor: Use override instead of virtual where possible #4917

merged 57 commits into from
Oct 25, 2023

Commits on Oct 24, 2023

  1. AccountController: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f1a280c View commit details
    Browse the repository at this point in the history

  2. FilterModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3235e1f View commit details
    Browse the repository at this point in the history

  3. IgnoreModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8c7358a View commit details
    Browse the repository at this point in the history

  4. MutedChannelModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ddaf1b9 View commit details
    Browse the repository at this point in the history

  5. ModerationActionModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b5b7f85 View commit details
    Browse the repository at this point in the history

  6. AccountModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    284f8b2 View commit details
    Browse the repository at this point in the history

  7. BadgeHighlightModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8c9880f View commit details
    Browse the repository at this point in the history

  8. HighlightBlacklistModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4a251cb View commit details
    Browse the repository at this point in the history

  9. HighlightModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2a889f7 View commit details
    Browse the repository at this point in the history

  10. UserHighlightModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    eb9a370 View commit details
    Browse the repository at this point in the history

  11. CommandModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    de19023 View commit details
    Browse the repository at this point in the history

  12. CommandController: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    345984b View commit details
    Browse the repository at this point in the history

  13. HotkeyModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2af35ef View commit details
    Browse the repository at this point in the history

  14. NotificationController: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5ce82da View commit details
    Browse the repository at this point in the history

  15. NotificationModel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    465a072 View commit details
    Browse the repository at this point in the history

  16. TwitchAccount: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fc6a033 View commit details
    Browse the repository at this point in the history

  17. TwitchIrcServer: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    78cba7a View commit details
    Browse the repository at this point in the history

  18. TwitchChannel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f514d11 View commit details
    Browse the repository at this point in the history

  19. TwitchChannel: Remove virtual from functions that shouldn't be virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d601343 View commit details
    Browse the repository at this point in the history

  20. FfzBadges: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9cd2086 View commit details
    Browse the repository at this point in the history

  21. ChatterinoBadges: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c1bb5ac View commit details
    Browse the repository at this point in the history

  22. AbstractIrcServer: Use override instead of virtual for dtor

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b508f30 View commit details
    Browse the repository at this point in the history

  23. IrcChannel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    f82f937 View commit details
    Browse the repository at this point in the history

  24. Irc inline model: use override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1977a54 View commit details
    Browse the repository at this point in the history

  25. LambdaRunnable: Make run override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    29cc965 View commit details
    Browse the repository at this point in the history

  26. LambdaRunnable: Initialize action_ in member initializer list

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    87017f5 View commit details
    Browse the repository at this point in the history

  27. InputCompletionItem: Remove redundant virtual (& public)

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    60eb149 View commit details
    Browse the repository at this point in the history

  28. ComboBoxItemDelegate: Use override instead of virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2e1482f View commit details
    Browse the repository at this point in the history

  29. Line: Use override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    705e2e5 View commit details
    Browse the repository at this point in the history

  30. NotebookButton: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    53dd3a5 View commit details
    Browse the repository at this point in the history

  31. QColorPicker: use override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3421bad View commit details
    Browse the repository at this point in the history

  32. SettingsDialogTab: use override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e8ee8ae View commit details
    Browse the repository at this point in the history

  33. SignalLabel: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    6ba7c10 View commit details
    Browse the repository at this point in the history

  34. SignalVectorModel: use override instead of virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9d5a84a View commit details
    Browse the repository at this point in the history

  35. Label: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5243b19 View commit details
    Browse the repository at this point in the history

  36. NewPopupItem: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    5e645e3 View commit details
    Browse the repository at this point in the history

  37. SelectChannelDialog: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    cc6c8c3 View commit details
    Browse the repository at this point in the history

  38. NewTabItem: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c8dd70b View commit details
    Browse the repository at this point in the history

  39. ColorPickerDialog: Mark dtor as override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    37fb21f View commit details
    Browse the repository at this point in the history

  40. IrcConnectionEditor: Mark dtor as override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    089492c View commit details
    Browse the repository at this point in the history

  41. SettingsDialog: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2c59f06 View commit details
    Browse the repository at this point in the history

  42. Emotes: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    720ba58 View commit details
    Browse the repository at this point in the history

  43. Fonts: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    7f56c9b View commit details
    Browse the repository at this point in the history

  44. Logging: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3ab6cd8 View commit details
    Browse the repository at this point in the history

  45. WindowManager: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    fd99e5a View commit details
    Browse the repository at this point in the history

  46. AttachedWindow: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    b943962 View commit details
    Browse the repository at this point in the history

  47. BaseWidget: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    c5384d4 View commit details
    Browse the repository at this point in the history

  48. BaseWindow: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a17d021 View commit details
    Browse the repository at this point in the history

  49. Notebook: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    453a909 View commit details
    Browse the repository at this point in the history

  50. UserInfoPopup: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    46f60dd View commit details
    Browse the repository at this point in the history

  51. SwitchSplitItem: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    482783d View commit details
    Browse the repository at this point in the history

  52. Button: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1c43163 View commit details
    Browse the repository at this point in the history

  53. NotebookTab: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    aab4650 View commit details
    Browse the repository at this point in the history

  54. QColorLuminancePicker: add override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    efb2894 View commit details
    Browse the repository at this point in the history

  55. GenericItemDeletage: Add override to dtor

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2534fb1 View commit details
    Browse the repository at this point in the history

  56. GenericListView: Remove redundant virtual

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0d143e1 View commit details
    Browse the repository at this point in the history

  57. GeneralPage: Add override

    @pajlada
    pajlada committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    90ef552 View commit details
    Browse the repository at this point in the history