Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the debug count/-popup to be able to format large numbers and data sizes properly. The following changes were made in the commits:
cpp
file.DebugCount::Flag(s)
andDebugCount::configure(name, flags)
.QMap
tostd::map
(order is important here).QStringBuilder
for concatenations.QLocale
for formatting (adds separators).DebugCount::Flag::DataSize
for data sizes in bytes (and fixed language to English).DataSize
for image sizes (maybe this should be moved somewhere else?).