-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve reply popup after thread update #4923
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me 👍. Just two small things I noticed.
'Reply to message' now replies to the correct message rather than thread root
It would be great if there was a menu option like 'Rep&ly to thread' which would reply to the thread root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
and don't rely on expired()
Also only call it if we actually found a message
Follow-up to #4919 (review)
Closes #4762
Reply to original thread
menu action