refactor: IrcMessageHandler

CHANGELOG.md

@@ -46,6 +46,7 @@
 - Dev: Refactor `DebugCount` and add copy button to debug popup. (#4921)
 - Dev: Changed lifetime of context menus. (#4924)
 - Dev: Refactor `ChannelView`, removing a bunch of clang-tidy warnings. (#4926)
+- Dev: Refactor `IrcMessageHandler`, removing a bunch of clang-tidy warnings & changing its public API. (#4927)
 
 ## 2.4.6
 

src/providers/recentmessages/Impl.cpp

@@ -54,7 +54,6 @@ std::vector<Communi::IrcMessage *> parseRecentMessages(
 std::vector<MessagePtr> buildRecentMessages(
     std::vector<Communi::IrcMessage *> &messages, Channel *channel)
 {
-    auto &handler = IrcMessageHandler::instance();
     std::vector<MessagePtr> allBuiltMessages;
 
     for (auto *message : messages)
@@ -78,8 +77,8 @@ std::vector<MessagePtr> buildRecentMessages(
             }
         }
 
-        auto builtMessages =
-            handler.parseMessageWithReply(channel, message, allBuiltMessages);
+        auto builtMessages = IrcMessageHandler::parseMessageWithReply(
+            channel, message, allBuiltMessages);
 
         for (const auto &builtMessage : builtMessages)
         {