fix: prevent channelPointRewardAdded invocation while connecting

[iProdigy]

Follow-up PR 1/2 for #4942 - implements the mutex outlined in #3942 (comment)

[Nerixyz]

How does this "Fix first redemption of a channel points reward not appearing in rare cases"?

Both TwitchChannel::addChannelPointReward and IrcMessageHandler::addMessage [must] run on the GUI thread - they can't run concurrently. I can only see this introducing a deadlock condition where the addMessage call in the callback would result in another callback being added.

I feel like the whole reward handling should be refactored, and the signal business should be removed. Maybe with a multimap/unordered_multimap of reward-id → pending messages?

[iProdigy]

Both TwitchChannel::addChannelPointReward and IrcMessageHandler::addMessage [must] run on the GUI thread - they can't run concurrently.

Ah, I assumed the signals weren't guaranteed to run on the same thread but this is wrong, closing.

I can only see this introducing a deadlock condition where the addMessage call in the callback would result in another callback being added.

That deadlock shouldn't happen since channelPointRewards_ would contain the reward, so another callback would not be created

I feel like the whole reward handling should be refactored, and the signal business should be removed. Maybe with a multimap/unordered_multimap of reward-id → pending messages?

I'm not opposed