Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove Outcome from network requests #4959

Merged
merged 2 commits into from
Nov 12, 2023
Merged

refactor: Remove Outcome from network requests #4959

merged 2 commits into from
Nov 12, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Nov 11, 2023

Description

As explained in the issue, the return value was never used.

Closes #4909.

pajlada
pajlada reviewed Nov 11, 2023
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can also just remove the outcome.hpp file & its cmakelists entry
EDIT: nvm it's still used in places

@fourtf
Copy link
Member

fourtf commented Nov 11, 2023

RIP Outcome, it was my favorite

@pajlada pajlada merged commit 6faf63c into Chatterino:master Nov 12, 2023
14 of 15 checks passed
@Nerixyz Nerixyz deleted the refactor/remove-net-outcome branch November 12, 2023 13:52
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Outcome from network callbacks
3 participants
@Nerixyz @fourtf @pajlada