Finish renaming Viewer list to Chatter list #4974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
approved these changes
Nov 20, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1364,8 +1364,8 @@ | |||
|
|
|||
| HotkeyController::HotkeyMap actions{ | |||
| {"delete", | |||
| [viewerDock](std::vector<QString>) -> QString { | |||
| viewerDock->close(); | |||
| [chatterDock](std::vector<QString>) -> QString { | |||
There was a problem hiding this comment.
warning: the parameter #1 is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param]
Suggested change
| [chatterDock](std::vector<QString>) -> QString { | |
| [chatterDock](const std::vector<QString>&) -> QString { |
Mm2PL
deleted the
chore/finish_renaming_viewers_list_to_chatters_list
branch
| item->setText(text); | ||
| item->setFont(getApp()->fonts->getFont(FontStyle::ChatMedium, 1.0)); | ||
| return item; | ||
| }; | ||
|
|
||
| auto addLabel = [this, formatListItemText, chattersList](QString label) { | ||
| auto formattedLabel = formatListItemText(label); | ||
| auto *formattedLabel = formatListItemText(label); |
There was a problem hiding this comment.
warning: parameter 'label' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
Suggested change
| auto *formattedLabel = formatListItemText(label); | |
| auto *formattedLabel = formatListItemText(std::move(label)); |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4640.