fix: ignore late pings #5457
Merged
fix: ignore late pings #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sleeping, both incoming messages and timer invocations are stalled and (kind of) replayed when waking up (i.e.
Communi::IrcConnection::messageReceivedwill fire pending events after waking up andpingTimer_will fire the pending ping). This leads to a heartbeat.The logs before are from SevenTV/chatterino7@chatterino7...355acd5 and the logs after are from SevenTV/chatterino7@chatterino7...nerix/rm-logging.
Logs before
Logs after
Fixes #5453.